Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

WIP: support the new unixfs-engine balanced builder #106

Closed
wants to merge 1 commit into from

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Jan 10, 2017

Changes in tests reflecting the new results from the new default balanced builder in unixfs-engine.

Depends on merging ipfs-inactive/js-ipfs-unixfs-engine#118

@daviddias
Copy link
Contributor

I've run these changes with js-ipfs-api against go-ipfs and since the expected hashes changed, the tests fail, they both should yield the same hashes for the same files

I checked to see if it could have been the change from raw to file (that could had happen in the other direction), but it seems that unixfs-engine is good with regards to that.

@pgte
Copy link
Contributor Author

pgte commented Jan 10, 2017

Nevermind, I hadn't realised that the test files were relatively small.
By the way, the difference with go-ipfs is that, for a file that is only one chunk, go-ipfs does not put a single link parent in front of it (going against what it does when recursing).
Tests against ipfs-inactive/js-ipfs-unixfs-engine#118 should be passing now.

@pgte pgte closed this Jan 10, 2017
@daviddias daviddias deleted the feat/unixfs-builders branch January 10, 2017 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants